Skip to content

Add FVO2 for curved 3D meshes#2755

Merged
DanielDoehring merged 13 commits intotrixi-framework:mainfrom
ArturYeritsyan:volume-integral-shock-rrg-3d
Jan 22, 2026
Merged

Add FVO2 for curved 3D meshes#2755
DanielDoehring merged 13 commits intotrixi-framework:mainfrom
ArturYeritsyan:volume-integral-shock-rrg-3d

Conversation

@ArturYeritsyan
Copy link
Copy Markdown
Contributor

@ArturYeritsyan ArturYeritsyan commented Jan 22, 2026

I have added fvO2 solver for the 3D StructuredMesh, P4estMesh, T8codeMesh and an example on a real curved mesh.
And a convergence test done on a curved mesh:
convergence_p4estmesh_3D_curved

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2026

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.03%. Comparing base (9e4eec3) to head (132c1a2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2755   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         568      569    +1     
  Lines       44429    44471   +42     
=======================================
+ Hits        43109    43151   +42     
  Misses       1320     1320
Flag Coverage Δ
unittests 97.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DanielDoehring
DanielDoehring requested changes Jan 22, 2026
View reviewed changes
@DanielDoehring DanielDoehring changed the title Added fvO2 for some 3D meshes Add FVO2 for curved 3D meshes Jan 22, 2026
@DanielDoehring
Copy link
Copy Markdown
Member

DanielDoehring commented Jan 22, 2026

The tests are also missing right now

@ArturYeritsyan
Copy link
Copy Markdown
Contributor Author

ArturYeritsyan commented Jan 22, 2026

i have added the convergence test.

@DanielDoehring
Copy link
Copy Markdown
Member

DanielDoehring commented Jan 22, 2026

i have added the convergence test.

Can you also add a test for the free stream elixir? This way we make sure this property is also preserved in the future.

@ArturYeritsyan
Copy link
Copy Markdown
Contributor Author

ArturYeritsyan commented Jan 22, 2026

yes i have added it

DanielDoehring
DanielDoehring approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DanielDoehring DanielDoehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArturYeritsyan !

@DanielDoehring DanielDoehring enabled auto-merge (squash) January 22, 2026 22:52
@DanielDoehring DanielDoehring merged commit 7e3481e into trixi-framework:main Jan 22, 2026
39 checks passed
@DanielDoehring DanielDoehring mentioned this pull request Jan 23, 2026
Open
ranocha
ranocha reviewed Jan 23, 2026
View reviewed changes
DanielDoehring added a commit to DanielDoehring/Trixi.jl that referenced this pull request Feb 19, 2026
@ArturYeritsyan @DanielDoehring
Add FVO2 for curved 3D meshes (trixi-framework#2755)
03fee26 
* add second order fv for 3D structured mesh

* small change

* Update src/solvers/dgsem_structured/dg_3d.jl

* add 3d p4est mesh for fv02

* add 3d t8code mesh for fvO2

* change to a non-cartesian mesh

* add fv02 example with real curved mesh

* delete some not needed files

* apply all suggested changes

* delete not needed file

* add free stream test

* Update examples/p4est_3d_dgsem/elixir_euler_free_stream_extruded_fvO2.jl

---------

Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranocha ranocha ranocha left review comments

@DanielDoehring DanielDoehring DanielDoehring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArturYeritsyan @DanielDoehring @ranocha